-
Notifications
You must be signed in to change notification settings - Fork 562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ListboxInput]: Update submit button querySelector specificity #903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit ed8795a:
|
jeffgrannes
changed the title
Update submit button querySelector specificity
Listbox: Update submit button querySelector specificity
Jan 27, 2022
jeffgrannes
changed the title
Listbox: Update submit button querySelector specificity
[Listbox]: Update submit button querySelector specificity
Jan 27, 2022
jeffgrannes
changed the title
[Listbox]: Update submit button querySelector specificity
[ListboxInput]: Update submit button querySelector specificity
Feb 2, 2022
@chaance, could you take a look at this? We need this change in order to pass our a11y compliance audit. |
chaance
approved these changes
Apr 20, 2022
chaance
pushed a commit
that referenced
this pull request
Jul 15, 2022
This was referenced Aug 2, 2022
This was referenced Aug 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, our website has a Listbox within a form. When we press enter on the Listbox, it is currently clicking the first button that it finds on the page and not our submit button. This PR updates the specificity of the selector to select the first button without a type or the first item with type=submit.
Thank you!
yarn test
).yarn start
).This pull request:
[ListBox] KeyDownEnter click first button it finds. #904
If creating a new package:
examples
directorysrc
directory with anindex.tsx
entry filestyle.css
file (if needed by the new package)