Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove slider width styling #673

Merged
merged 1 commit into from
Nov 25, 2020
Merged

Remove slider width styling #673

merged 1 commit into from
Nov 25, 2020

Conversation

danny-andrews
Copy link
Contributor

Setting the slider to have a width of 350px seems really arbitrary and is almost never what you want. Typically, inputs default to taking up the full width of a container and I don't see why a slider should be any different.

AFAIK the styling that reach-ui ships with is the minimum to make the component functional, and this css rule seems to go against that.

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code (Compile and run).
  • Add or edit tests to reflect the change (Run with yarn test).
  • Add or edit Storybook examples to reflect the change (Run with yarn start).
  • Ensure formatting is consistent with the project's Prettier configuration.
  • Add documentation to support any new features.

This pull request:

  • Creates a new package
  • Fixes a bug in an existing package
  • Adds additional features/functionality to an existing package
  • Updates documentation or example code
  • Other

If creating a new package:

  • Make sure the new package directory contains each of the following, and that their structure/formatting mirrors other related examples in the project:
    • examples directory
    • src directory with an index.tsx entry file
    • At least one example file per feature introduced by the new package
    • Base styles in a style.css file (if needed by the new package)

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit afae759:

Sandbox Source
reach/reach-ui: reach-ui Configuration

@chaance chaance added the Type: Enhancement General improvements or suggestions label Nov 25, 2020
@chaance chaance merged commit 9e3e4bc into reach:develop Nov 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement General improvements or suggestions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants