Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tabs: avoid text jumps while switching #621

Merged
merged 1 commit into from
Aug 21, 2020
Merged

Conversation

kripod
Copy link
Contributor

@kripod kripod commented Jun 18, 2020

Supersedes #600.

Thank you for contributing to Reach UI! Please fill in this template before submitting your PR to help us process your request more quickly.

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code (Compile and run).
  • Add or edit tests to reflect the change (Run with yarn test).
  • Add or edit Storybook examples to reflect the change (Run with yarn start).
  • Ensure formatting is consistent with the project's Prettier configuration.

This pull request:

  • Creates a new package
  • Fixes a bug in an existing package
  • Adds additional features/functionality to an existing package
  • Updates documentation or example code
  • Other

@kripod kripod mentioned this pull request Jun 18, 2020
10 tasks
@stale stale bot closed this Aug 1, 2020
@kripod
Copy link
Contributor Author

kripod commented Aug 1, 2020

This is not stale, but awaiting for review. (@chancestrickland?)

@chaance chaance reopened this Aug 16, 2020
@stale stale bot removed the Resolution: Stale label Aug 16, 2020
@chaance chaance added the Type: Enhancement General improvements or suggestions label Aug 21, 2020
@chaance chaance merged commit b1bf222 into reach:develop Aug 21, 2020
@kripod kripod deleted the patch-2 branch August 21, 2020 17:15
afzalsayed96 pushed a commit to afzalsayed96/reach-ui that referenced this pull request Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement General improvements or suggestions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants