Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Combobox] Clear value when input focused after interacting with popover #546

Merged
merged 1 commit into from
Apr 11, 2020

Conversation

indiesquidge
Copy link
Collaborator

@indiesquidge indiesquidge commented Apr 10, 2020

Summary

Before

Typing in the input, tabbing to an interactive element in the listbox, focusing the input again, then attempting to delete the entire input value with + ("command + backspace" on macOS) is a noop for the input value. Notice that the controlled value is updated properly.

combobox-before

After

Same sequence as above works as expected—the value is properly cleared on + .

combobox-after


  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code (Compile and run).
  • Add or edit tests to reflect the change (Run with yarn test).
  • Add or edit Storybook examples to reflect the change (Run with yarn start).
  • Ensure formatting is consistent with the project's Prettier configuration.

This pull request:

  • Creates a new package
  • Fixes a bug in an existing package
  • Adds additional features/functionality to an existing package
  • Updates documentation or example code
  • Other

@enforce-template-use
Copy link

Thank you for the pull request

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 27f929d:

Sandbox Source
nervous-wood-cnt8q Configuration

@chaance chaance added the Type: Bug Something isn't working label Apr 11, 2020
@chaance chaance merged commit acd5ec7 into reach:master Apr 11, 2020
@indiesquidge indiesquidge deleted the combobox-clear-input-bug branch April 11, 2020 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants