Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add positionRight helper to Popover #484

Merged
merged 1 commit into from
Apr 5, 2020
Merged

Add positionRight helper to Popover #484

merged 1 commit into from
Apr 5, 2020

Conversation

NerdCowboy
Copy link
Contributor

Thank you for contributing to Reach UI! Please fill in this template before submitting your PR to help us process your request more quickly.

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code (Compile and run).
  • Add or edit tests to reflect the change (Run with yarn test).
  • Add or edit Storybook examples to reflect the change (Run with yarn start).
  • Ensure formatting is consistent with the project's Prettier configuration.

This pull request:

  • Creates a new package

  • Fixes a bug in an existing package

  • Adds additional features/functionality to an existing package

  • Updates documentation or example code

  • Other

  • Adds helper positionRight to set default alignment
    of popover to the right

  • Create getTopPosition abstraction since same logic
    is now used in 3 places

- Adds helper positionRight to set default alignment
of popover to the right
- Create getTopPosition abstraction since same logic
was used in 3 places
@enforce-template-use
Copy link

Thank you for the pull request

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@chaance chaance self-assigned this Feb 20, 2020
@chaance chaance added the Type: Enhancement General improvements or suggestions label Feb 20, 2020
@chaance chaance merged commit 3b74cea into reach:master Apr 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Resolution: Stale Type: Enhancement General improvements or suggestions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants