Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MenuButton: Allow user to set MenuButton ID #292

Merged
merged 1 commit into from
Oct 9, 2019
Merged

MenuButton: Allow user to set MenuButton ID #292

merged 1 commit into from
Oct 9, 2019

Conversation

chaance
Copy link
Member

@chaance chaance commented Oct 9, 2019

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code (Compile and run).
  • Add or edit tests to reflect the change (Run with yarn test).
  • Add or edit Storybook examples to reflect the change (Run with yarn start).
  • Ensure formatting is consistent with the project's Prettier configuration.

This pull request:

  • Creates a new package
  • Fixes a bug in an existing package: Fixes menu-button: button id issues #25
  • Adds additional features/functionality to an existing package
  • Updates documentation or example code
  • Other

@chaance chaance requested a review from mjackson October 9, 2019 01:45
@chaance chaance added the Type: Bug Something isn't working label Oct 9, 2019
@chaance chaance merged commit 56a6c49 into master Oct 9, 2019
@chaance chaance deleted the menu-button-id branch October 9, 2019 17:45
chaance pushed a commit that referenced this pull request Oct 23, 2019
menu-button: allow user to set MenuButton ID (#292)
174effb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjackson mjackson Awaiting requested review from mjackson

Assignees
No one assigned
Labels
Type: Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@chaance