Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Critical rendering issue with AlertDialog / AlertDialogContent #139

Closed
coreylight opened this issue Apr 12, 2019 · 4 comments
Closed

Critical rendering issue with AlertDialog / AlertDialogContent #139

coreylight opened this issue Apr 12, 2019 · 4 comments
Assignees
Labels
Status: Unconfirmed Bug reports without a repro, not yet confirmed

Comments

@coreylight
Copy link

Can't seem to get base functionality going:

Reproduction:
https://codesandbox.io/s/vy7pxoq697

@jewel-andraia
Copy link

jewel-andraia commented Apr 15, 2019

Previews on https://ui.reach.tech/alert-dialog are also throwing errors:

Invariant Violation: Minified React error #130; visit https://reactjs.org/docs/error-decoder.html?invariant=130&args[]=undefined&args[]= for the full message or use the non-minified dev environment for full errors and additional helpful warnings.

Screen Shot 2019-04-14 at 7 43 18 PM

@osartun
Copy link

osartun commented Apr 26, 2019

Same error here.
However, I already read the code and don't understand why it would say something would be undefined there. Can't figure out where the issue comes from.

It's related to #133
It uses the <IdConsumer>, but this component was deleted recently.

@cweeii
Copy link

cweeii commented Apr 26, 2019

I've noticed something strange too that when I do an explicit install of @reach/utils instead of yarn bootstrap and linking, the lib folder and <IdConsumer> is there.

@bradwestfall bradwestfall added the Status: Unconfirmed Bug reports without a repro, not yet confirmed label Oct 1, 2019
@chaance
Copy link
Member

chaance commented Oct 14, 2019

Closing, as this should be fixed. See #133 for more info.

@chaance chaance closed this as completed Oct 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Unconfirmed Bug reports without a repro, not yet confirmed
Projects
None yet
Development

No branches or pull requests

6 participants