Focus trapping stops working

[mkarajohn]

CodeSandbox link (better see it in its own tab)

Bug description

• We have 2 siblings DialogOverlay components (DialogOverlay 1 and 2)
• We open 1
• Keyboard navigation keeps focus trapped inside DialogOverlay 1
• We open 2 while 1 is still open
• Keyboard navigation keeps focus trapped inside DialogOverlay 2
• Close 2
• Keyboard navigation does not keep focus trapped inside DialogOverlay 1, focus escapes the overlay component

Expected behaviour

Focus trapping for each DialogOverlay should not be affected by other DialogOverlays

Notes

Could be related to #83 (comment) ?

[simonccarter]

If you update the @reach/dialog dependency in the codesandbox example from 0.1.4 to 0.2.9, the problem goes away. Possibly fixed by moving to react-focus-lock. I think this can be closed now?

[mkarajohn]

Yep, just checked, it's fixed. In the end, react-focus-lock is what I opted to use in my project as well.