marked optional params

reach · Jan 13, 2019 · a69165c · a69165c
1 parent d78e394
commit a69165c
Show file tree

Hide file tree

Showing 5 changed files with 16 additions and 14 deletions.
diff --git a/packages/alert-dialog/index.d.ts b/packages/alert-dialog/index.d.ts
@@ -2,9 +2,9 @@ declare module "@reach/alert-dialog" {
   import { DialogProps, DialogContentProps } from "@reach/dialog";
 
   type AlertDialogProps = {
-    isOpen: boolean;
-    onDismiss: () => void;
-    leastDestructiveRef: React.RefObject<HTMLElement>;
+    isOpen?: boolean;
+    onDismiss?: () => void;
+    leastDestructiveRef?: React.RefObject<HTMLElement>;
     children: React.ReactNode;
   } & DialogProps;
 

diff --git a/packages/component-component/index.d.ts b/packages/component-component/index.d.ts
@@ -13,7 +13,7 @@ declare module "@reach/component-component" {
 
   type Refs = { [key: string]: React.RefObject<HTMLElement> };
 
-  type StateProps = Pick<Args<{}, {}>, "state" | "props">;
+  type StateProps<P, S> = Pick<Args<{}, {}>, "state" | "props">;
 
   export type ComponentProps<P, S> = {
     initialState?: S;
@@ -22,11 +22,13 @@ declare module "@reach/component-component" {
     getRefs?(): Refs;
     didMount?(args: Args<P, S> & Refs): void;
     didUpdate?(args: Args<P, S> & Refs & { prevProps: P; prevState: S }): void;
-    willUnmount?(args: StateProps & Refs): void;
+    willUnmount?(args: StateProps<P, S> & Refs): void;
     getSnapshotBeforeUpdate?(
-      args: StateProps & Refs & { prevProps: P; prevState: S }
+      args: StateProps<P, S> & Refs & { prevProps: P; prevState: S }
     ): any;
-    shouldUpdate?(args: StateProps & { nextProps: P; nextState: S }): boolean;
+    shouldUpdate?(
+      args: StateProps<P, S> & { nextProps: P; nextState: S }
+    ): boolean;
     children?(
       args: Args<P, S> & Refs
     ): Args<P, S> & Refs | React.ReactNode | null;

diff --git a/packages/dialog/index.d.ts b/packages/dialog/index.d.ts
@@ -1,6 +1,6 @@
 declare module "@reach/dialog" {
-  type DialogProps = {
-    isOpen: boolean;
+  export type DialogProps = {
+    isOpen?: boolean;
     onDismiss?: () => void;
     children: React.ReactNode;
   } & HTMLDivElement;

diff --git a/packages/portal/index.d.ts b/packages/portal/index.d.ts
@@ -1,7 +1,7 @@
 declare module "@reach/portal" {
   type PortalProps = {
+    type?: string;
     children: React.ReactNode;
-    type: string;
   };
 
   export const Portal: React.SFC<PortalProps>;

diff --git a/packages/rect/index.d.ts b/packages/rect/index.d.ts
@@ -1,5 +1,5 @@
 declare module "@reach/rect" {
-  type IClientRect = {
+  interface IClientRect {
     x: number;
     y: number;
     width: number;
@@ -8,12 +8,12 @@ declare module "@reach/rect" {
     right: number;
     bottom: number;
     left: number;
-  };
+  }
 
   type IRectProps = {
+    observe?: boolean;
+    onChange?: (rect: IClientRect) => void;
     children: React.ReactNode;
-    observe: boolean;
-    onChange: (rect: IClientRect) => void;
   };
 
   const Rect: React.SFC<IRectProps>;