Prevent default for links to avoid double click events

reach · Jun 25, 2021 · 8a89495 · 8a89495
1 parent 1f2d2ee
commit 8a89495
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/packages/menu-button/src/index.tsx b/packages/menu-button/src/index.tsx
@@ -662,10 +662,10 @@ const MenuItems = React.forwardRef(function MenuItems(
           // consistent behavior across menu items we'll trigger a click when
           // the spacebar is pressed.
           if (selected) {
+            event.preventDefault();
             if (selected.isLink && selected.element) {
               selected.element.click();
             } else {
-              event.preventDefault();
               // Focus the button first by default when an item is selected.
               // We fire the onSelect callback next so the app can manage
               // focus if needed.