accordion: fix incorrect onChange type sig (#482)

reach · Feb 21, 2020 · 68f528d · 68f528d
1 parent 40b9e6f
commit 68f528d
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/packages/accordion/src/index.tsx b/packages/accordion/src/index.tsx
@@ -153,7 +153,7 @@ export const Accordion = forwardRef<HTMLDivElement, AccordionProps>(
     }
 
     const onSelectPanel = useCallback(
-      (index: AccordionIndex) => {
+      (index: number) => {
         onChange && onChange(index);
 
         if (!isControlled) {
@@ -263,7 +263,7 @@ export type AccordionProps = Omit<
    *
    * @see Docs https://reacttraining.com/reach-ui/accordion#accordion-onchange
    */
-  onChange?(index?: AccordionIndex): void;
+  onChange?(index?: number): void;
   /**
    * Whether or not an uncontrolled accordion is read-only or controllable by a
    * user interaction.
@@ -614,7 +614,7 @@ type ButtonRef = React.MutableRefObject<any>;
 type AccordionIndex = number | number[];
 
 interface IAccordionContext {
-  accordionId: string;
+  accordionId: string | undefined;
   openPanels: AccordionIndex;
   onSelectPanel(index: AccordionIndex): void;
   readOnly: boolean;

diff --git a/website/src/pages/accordion.mdx b/website/src/pages/accordion.mdx
@@ -330,7 +330,7 @@ Whether or not multiple panels in an uncontrolled accordion can be opened at the
 
 ##### Accordion `onChange`
 
-`onChange?: (value: number | number[]) => void`
+`onChange?: (value: number) => void`
 
 The callback that is fired when an accordion item's open state is changed.