Fix name of story and reset inputValueChangedRef when uncontrolled

reach · Apr 14, 2021 · 3112a81 · 3112a81
1 parent 2207cb4
commit 3112a81
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/packages/combobox/examples/simulated-change.example.js b/packages/combobox/examples/simulated-change.example.js
@@ -9,7 +9,7 @@ import {
 import { useCityMatch } from "./utils";
 import "@reach/combobox/styles.css";
 
-let name = "Controlled";
+let name = "Simulated Change";
 
 function Example() {
   let [term, setTerm] = React.useState("Detroit");
@@ -35,8 +35,8 @@ function Example() {
       <h2>Clientside Search</h2>
       <p>
         This example tests that changes to the controlled value of Combobox
-        don't trigger it to open unless we are actually typing. The initial
-        value and programmatically set value here shouldn't open the Popover.
+        don't expand it unless we are actually typing. The initial value and
+        programmatically set value here shouldn't open the Popover.
       </p>
       <p>Selection: {selection}</p>
       <p>Term: {term}</p>

diff --git a/packages/combobox/src/index.tsx b/packages/combobox/src/index.tsx
@@ -486,10 +486,10 @@ export const ComboboxInput = React.forwardRef(function ComboboxInput(
       (controlledValue!.trim() === "" ? (value || "").trim() !== "" : true)
     ) {
       handleValueChange(controlledValue!);
-      // After we handled the changed value, we need to make sure the next
-      // controlled change won't trigger a CHANGE event. (instead of a SIMULATED_CHANGE)
-      inputValueChangedRef.current = false;
     }
+    // After we handled the changed value, we need to make sure the next
+    // controlled change won't trigger a CHANGE event. (instead of a SIMULATED_CHANGE)
+    inputValueChangedRef.current = false;
   }, [controlledValue, handleValueChange, isControlled, value]);
 
   // [*]... and when controlled, we don't trigger handleValueChange as the