Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add GCP provider for cpu on vms #8

Merged
merged 1 commit into from
Nov 21, 2023
Merged

feat: add GCP provider for cpu on vms #8

merged 1 commit into from
Nov 21, 2023

Conversation

Spazzy757
Copy link
Contributor

Changelog

  • adds GCP provider for CPU utilization and count

@Spazzy757 Spazzy757 marked this pull request as draft November 10, 2023 14:59
@Spazzy757 Spazzy757 changed the title WIP: feat: add GCP provider for cpu on vms feat: add GCP provider for cpu on vms Nov 10, 2023
@Spazzy757 Spazzy757 force-pushed the feat-add-gcp-provider branch 11 times, most recently from c02345e to 5e2e5c9 Compare November 14, 2023 13:42
@Spazzy757 Spazzy757 force-pushed the feat-add-gcp-provider branch 2 times, most recently from e1ea401 to 8ac904b Compare November 14, 2023 13:49
@Spazzy757 Spazzy757 marked this pull request as ready for review November 14, 2023 13:50
@Spazzy757
Copy link
Contributor Author

@gabibeyer @silenteh This is just a first pass, I need to move the metric types to the global ones once that is merged into main. Also have some edge cases to handle, but will be easier to do once using the Global metrics

@Spazzy757 Spazzy757 force-pushed the feat-add-gcp-provider branch 2 times, most recently from 8ac904b to eca8686 Compare November 14, 2023 13:53
@Spazzy757 Spazzy757 self-assigned this Nov 14, 2023
@Spazzy757 Spazzy757 added the enhancement New feature or request label Nov 14, 2023
gabibeyer
gabibeyer reviewed Nov 15, 2023
View reviewed changes
Copy link
Contributor

@gabibeyer gabibeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great starting point! Just one comment on the client logic

@Spazzy757 Spazzy757 force-pushed the feat-add-gcp-provider branch 6 times, most recently from c92cfa2 to 43cfa81 Compare November 15, 2023 15:30
@Spazzy757 Spazzy757 force-pushed the feat-add-gcp-provider branch 6 times, most recently from 8cb666e to 70b22e5 Compare November 15, 2023 15:38
@gabibeyer gabibeyer self-requested a review November 16, 2023 09:32
gabibeyer
gabibeyer previously approved these changes Nov 16, 2023
View reviewed changes
silenteh
silenteh previously approved these changes Nov 16, 2023
View reviewed changes
@Spazzy757 Spazzy757 dismissed stale reviews from silenteh and gabibeyer via 007ccad November 20, 2023 12:35
@Spazzy757 Spazzy757 force-pushed the feat-add-gcp-provider branch 3 times, most recently from 8dcdb03 to 093172b Compare November 20, 2023 15:05
@Spazzy757
feat: add GCP provider for cpu on vms
3f496ff 
Signed-off-by: Spazzy <brendankamp757@gmail.com>
@Spazzy757 Spazzy757 force-pushed the feat-add-gcp-provider branch from 093172b to 3f496ff Compare November 20, 2023 15:05
@Spazzy757 Spazzy757 merged commit cf46f96 into main Nov 21, 2023
@Spazzy757 Spazzy757 deleted the feat-add-gcp-provider branch November 21, 2023 13:20
@gabibeyer
Copy link
Contributor

lol

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@silenteh silenteh silenteh approved these changes

@gabibeyer gabibeyer gabibeyer approved these changes

Assignees

@Spazzy757 Spazzy757

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Spazzy757 @gabibeyer @silenteh