Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create Plugin Health check #78

Closed
Spazzy757 opened this issue Apr 9, 2024 · 2 comments · Fixed by #89 or #91
Closed

Create Plugin Health check #78

Spazzy757 opened this issue Apr 9, 2024 · 2 comments · Fixed by #89 or #91
Labels
bug Something isn't working plugins issues related to the plugin system

Comments

@Spazzy757
Copy link
Contributor

Situation

currently there is no way for aether to know if a plugin has terminated, we should build in a liveness check and restart a plugin if it dies.

we could use the rpc Ping() functionality for this
@Spazzy757 Spazzy757 added bug Something isn't working plugins issues related to the plugin system labels Apr 9, 2024
@Spazzy757
Copy link
Contributor Author

There is this open issue with go-plugin: hashicorp/go-plugin#92

gabibeyer added a commit that referenced this issue Apr 12, 2024
@gabibeyer
feat: Store energy consumption along with emissions
3770dbc 
Closes #78
Store the calculated energy consumption for each metric in the
Metric data type. This allows it to be stored in the instance
and sent to the exporters as a possible datapoint along with
carbon emission equivalents and embodied emissions.
@gabibeyer gabibeyer mentioned this issue Apr 12, 2024
Merged
gabibeyer added a commit that referenced this issue Apr 12, 2024
@gabibeyer
feat: Store energy consumption along with emissions
240a143 
Closes #78
Store the calculated energy consumption for each metric in the
Metric data type. This allows it to be stored in the instance
and sent to the exporters as a possible datapoint along with
carbon emission equivalents and embodied emissions.
@gabibeyer
Copy link
Contributor

Linked the wrong issue

@gabibeyer gabibeyer reopened this Apr 12, 2024
@Spazzy757 Spazzy757 mentioned this issue Apr 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working plugins issues related to the plugin system
Projects
None yet
Milestone
No milestone
2 participants
@gabibeyer @Spazzy757