Skip to content

Commit

Permalink
don't Implement Display for Val (bevyengine#10345)
Browse files Browse the repository at this point in the history
# Objective

- Revert bevyengine#10296 

## Solution

- Avoid implementing `Display` without a justification
- `Display` implementation is a guarantee without a direct use, takes
additional time to compile and require work to maintain
- `Debug`, `Reflect` or `Serialize` should cover all needs
  • Loading branch information
mockersf authored and Ray Redondo committed Jan 9, 2024
1 parent 6eb352b commit 56d79a0
Showing 1 changed file with 0 additions and 17 deletions.
17 changes: 0 additions & 17 deletions crates/bevy_ui/src/geometry.rs
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ use bevy_reflect::ReflectDeserialize;
use bevy_reflect::ReflectSerialize;
use serde::Deserialize;
use serde::Serialize;
use std::fmt::Display;
use std::ops::Neg;
use std::ops::{Div, DivAssign, Mul, MulAssign};
use thiserror::Error;
Expand Down Expand Up @@ -156,22 +155,6 @@ impl DivAssign<f32> for Val {
}
}

impl Display for Val {
fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
let (value, suffix) = match self {
Val::Auto => return write!(f, "auto"),
Val::Px(value) => (value, "px"),
Val::Percent(value) => (value, "%"),
Val::Vw(value) => (value, "vw"),
Val::Vh(value) => (value, "vh"),
Val::VMin(value) => (value, "vmin"),
Val::VMax(value) => (value, "vmax"),
};
value.fmt(f)?;
write!(f, "{suffix}")
}
}

impl Neg for Val {
type Output = Val;

Expand Down

0 comments on commit 56d79a0

Please sign in to comment.