A couple of minor improvements #96
Conversation
show chirality labels in the renderers bump nodes version
| @@ -137,7 +138,7 @@ public ImageData getImageData() { | |||
|
|
|||
| // We use the pref store of the UI plugin | |||
| setPreferenceStore(RDKitNodePlugin.getDefault().getPreferenceStore()); | |||
| setDescription("This section contains sub sections to control preferences for RDKit Nodes."); | |||
| setDescription("This section contains sub sections to control preferences for the RDKit Nodes.\nThe nodes are using version "+RDKFuncs.getRdkitVersion()+" of the RDKit backend."); | |||
There was a problem hiding this comment.
yeah, I think this will be quite useful
| @@ -417,6 +418,8 @@ public StreamableOperator createStreamableOperator(PartitionInfo partitionInfo, | |||
| } | |||
|
|
|||
| final MolDraw2DSVG molDrawing = markForCleanup(new MolDraw2DSVG(300, 300), lUniqueWaveId); | |||
| MolDrawOptions opts = molDrawing.drawOptions(); | |||
There was a problem hiding this comment.
Shouldn't this also be wrapped in markForCleanup(..., lUniqueWaveId) ? There is a chance that it gets cleaned up with its parent object MolDraw2DSVG, but if in doubt (and I usually am, because you cannot look into that type of code) I would always call the delete() function at the end. The cleanup code handles it properly, if marked for cleanup.
There was a problem hiding this comment.
That's a good question, but that object doesn't own any memory of its own... it's just a reference to memory that the MolDraw2DSVG owns, so it should not cause a leak.
| @@ -2,7 +2,7 @@ | |||
| <feature | |||
| id="org.rdkit.knime.feature" | |||
| label="RDKit Nodes Feature" | |||
| version="4.3.0.qualifier" | |||
| version="4.3.1.qualifier" | |||
There was a problem hiding this comment.
If you merge this as planned with the RDKit binaries changes, you may just increment the version number together with the binaries change as discussed there. All version numbers should be in sync at the end.
There was a problem hiding this comment.
yeah, these changes were made as part of the RDKit binaries merge, so they are in sync now
|
@manuelschwarze : the requested change (to the version number) was made as part of the binaries PR, so that's no longer relevant. I think that's the only actual requested change, so I will merge this later unless you have an objection |
Changes here:
show chirality and enhanced stereo labels in the renderers
show the version number of the RDKit backend in the preferences page:
bump nodes version
This can stand on it's own, but I would really prefer to have #95 merged first, then this one.