New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Spec and Doc fixes for Release 1.3.1 #302

Merged

kevinshahfws merged 8 commits into next from feature-and-fixes-1-3-1

Aug 19, 2024

Contributor

kevinshahfws commented Aug 14, 2024 •

edited

Loading

This PR contains below fixes:

Create enum values in BooleanMap for device.hdr Response
Create enum values in BooleanMap for device.hdcp Response
Create enum values in BooleanMap for device.audio Response
Update device.videoResolution description and result
Update Device.screenResolution description and result
Update Accessibility.closedCaptionsSettings and Accessibility.closedCaptions key options
Update Accessibility.voiceGuidance and Accessibility.voiceGuidanceSettings key options
Update Advertising.appBundleId example
Update Advertising.advertisingId to define attributes and updated description
Update Advertising.policy capability to singular capability
Update description for Device.version


          fix: Spec and Doc fixes for Release 1.3.1

143f863

kevinshahfws requested review from jlacivita, satlead, alkalinecoffee and kpears201

August 14, 2024 16:05

github-actions bot commented Aug 14, 2024

Core SDK - MFOS standalone sanity report:
Passes - 199 Failures - 0 Pending - 0 Skipped - 8
Report JSON/HTML Files: https://github.com/rdkcentral/firebolt-apis/suites/27178417438/artifacts/1812273319
Job Logs: https://github.com/rdkcentral/firebolt-apis/actions/runs/10391059153

kpears201 reviewed

View reviewed changes

src/openrpc/device.json Outdated Show resolved Hide resolved


          fix: Addressed review comments

09a309b

kpears201 reviewed

View reviewed changes

src/openrpc/device.json Show resolved Hide resolved

kpears201 reviewed

View reviewed changes

src/openrpc/device.json Show resolved Hide resolved

kpears201 reviewed

View reviewed changes

src/openrpc/device.json Outdated Show resolved Hide resolved

github-actions bot commented Aug 14, 2024

Core SDK - MFOS standalone sanity report:
Passes - 199 Failures - 0 Pending - 0 Skipped - 8
Report JSON/HTML Files: https://github.com/rdkcentral/firebolt-apis/suites/27184021154/artifacts/1812881873
Job Logs: https://github.com/rdkcentral/firebolt-apis/actions/runs/10393024538

kpears201 reviewed

View reviewed changes

src/openrpc/device.json Outdated Show resolved Hide resolved

kpears201 reviewed

View reviewed changes

src/openrpc/device.json Outdated Show resolved Hide resolved

kpears201 reviewed

View reviewed changes

src/schemas/types.json Show resolved Hide resolved

kpears201 reviewed

View reviewed changes

src/openrpc/advertising.json Show resolved Hide resolved


          fix: Addressed review comments

bc82d26

github-actions bot commented Aug 14, 2024

Core SDK - MFOS standalone sanity report:
Passes - 199 Failures - 0 Pending - 0 Skipped - 8
Report JSON/HTML Files: https://github.com/rdkcentral/firebolt-apis/suites/27185713785/artifacts/1813060188
Job Logs: https://github.com/rdkcentral/firebolt-apis/actions/runs/10393605341

kpears201 reviewed

View reviewed changes

src/openrpc/device.json Outdated Show resolved Hide resolved

kpears201 reviewed

View reviewed changes

src/openrpc/device.json Outdated Show resolved Hide resolved


          fix: Removed deprecation notes

github-actions bot commented Aug 14, 2024

Core SDK - MFOS standalone sanity report:
Passes - 199 Failures - 0 Pending - 0 Skipped - 8
Report JSON/HTML Files: https://github.com/rdkcentral/firebolt-apis/suites/27188704023/artifacts/1813372231
Job Logs: https://github.com/rdkcentral/firebolt-apis/actions/runs/10394645498


          fix: Few more description changes

bc0f82d

github-actions bot commented Aug 14, 2024

Core SDK - MFOS standalone sanity report:
Passes - 199 Failures - 0 Pending - 0 Skipped - 8
Report JSON/HTML Files: https://github.com/rdkcentral/firebolt-apis/suites/27189560750/artifacts/1813463163
Job Logs: https://github.com/rdkcentral/firebolt-apis/actions/runs/10394925510

kpears201 previously approved these changes

View reviewed changes

alkalinecoffee previously approved these changes

View reviewed changes


          fix: Description fix

efc596e

kevinshahfws dismissed stale reviews from alkalinecoffee and kpears201 via

efc596e

August 15, 2024 16:11

github-actions bot commented Aug 15, 2024

Core SDK - MFOS standalone sanity report:
Passes - 199 Failures - 0 Pending - 0 Skipped - 8
Report JSON/HTML Files: https://github.com/rdkcentral/firebolt-apis/suites/27219278342/artifacts/1816459711
Job Logs: https://github.com/rdkcentral/firebolt-apis/actions/runs/10406841115

alkalinecoffee reviewed

View reviewed changes

src/openrpc/device.json Outdated Show resolved Hide resolved

kevinshahfws added 2 commits

August 19, 2024 14:37


          fix: Changed schema component name for HDCP and HDR

16673cd


          fix: Component description change

ba5826a

github-actions bot commented Aug 19, 2024

Core SDK - MFOS standalone sanity report:
Passes - 199 Failures - 0 Pending - 0 Skipped - 8
Report JSON/HTML Files: https://github.com/rdkcentral/firebolt-apis/suites/27345935385/artifacts/1829001142
Job Logs: https://github.com/rdkcentral/firebolt-apis/actions/runs/10459028198

github-actions bot commented Aug 19, 2024

Core SDK - MFOS standalone sanity report:
Passes - 199 Failures - 0 Pending - 0 Skipped - 8
Report JSON/HTML Files: https://github.com/rdkcentral/firebolt-apis/suites/27346091644/artifacts/1829015936
Job Logs: https://github.com/rdkcentral/firebolt-apis/actions/runs/10459082350

kpears201 approved these changes

View reviewed changes

alkalinecoffee approved these changes

View reviewed changes

kevinshahfws merged commit 6010a85 into next

8 checks passed

kevinshahfws mentioned this pull request

fix: update-spec-and-example #296

Closed

kschrief pushed a commit that referenced this pull request


          chore(release): 1.3.1-next.1 [skip ci]

1e87ab8

## [1.3.1-next.1](v1.3.0...v1.3.1-next.1) (2024-08-19)

### Bug Fixes

* Spec and Doc fixes ([#302](#302)) ([6010a85](6010a85))

Contributor

kschrief commented Aug 19, 2024

🎉 This PR is included in version 1.3.1-next.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

kschrief added the released on @next label

kschrief pushed a commit that referenced this pull request


          chore(release): 1.4.0 [skip ci]

0270f4c

# [1.4.0](v1.3.0...v1.4.0) (2024-09-23)

### Bug Fixes

* Added deprecation note in screen resolution method ([#323](#323)) ([e146c43](e146c43))
* Added individual sdk openrpcs to the doc specification ([#311](#311)) ([ace1d64](ace1d64))
* Addressed architectural review comments ([#316](#316)) ([a89275a](a89275a))
* Adjust type in CPP device template due to openrpc change ([#307](#307)) ([1f10a15](1f10a15))
* Bump firebolt-openrpc to fix typescript ([#305](#305)) ([62887cf](62887cf))
* CHANGELOG.md links ([972ab20](972ab20))
* CI fix for file exists ([#308](#308)) ([b44c11a](b44c11a))
* core CHANGELOG.md links ([9987742](9987742))
* Modified device.hdr description ([#319](#319)) ([fd2bfb0](fd2bfb0))
* Reverted App selection tag change ([#322](#322)) ([eee90e4](eee90e4))
* Spec and Doc fixes ([#302](#302)) ([6010a85](6010a85))
* Update to CHANGELOG.md for Release 1.4.0 ([a509cb6](a509cb6))
* Updated the artifact upload version for workflow ([#317](#317)) ([ef9b441](ef9b441))
* Updated xrn:firebolt:capability:secondscreen:protocol to should ([#310](#310)) ([1895fe6](1895fe6))

### Features

* Add global subscribe & HDMI tests to manage test app ([#320](#320)) ([63962ab](63962ab))
* Add OpenRPC to generated C++ SDK ([#314](#314)) ([6ed96cb](6ed96cb))
* Fix Core SDK test app ([#321](#321)) ([3a78534](3a78534))
* Spec and Doc fixes for Release 1.4.0 ([#304](#304)) ([191664b](191664b))

Contributor

kschrief commented Sep 23, 2024

🎉 This PR is included in version 1.4.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

kschrief added the released label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

released on @next released