Issue #45: Add missing spec methods to DataFactory interface

.changeset/afraid-donuts-retire.md

@@ -0,0 +1,5 @@
+---
+"@rdfjs/types": major
+---
+
+Add missing methods `fromTerm` and `fromQuad` to the `DataFactory` interface

data-model.d.ts

@@ -287,4 +287,19 @@ export interface DataFactory<OutQuad extends BaseQuad = Quad, InQuad extends Bas
      * @see Quad
      */
     quad(subject: InQuad['subject'], predicate: InQuad['predicate'], object: InQuad['object'], graph?: InQuad['graph']): OutQuad;
+
+    /**
+     * @param original The original term.
+     * @return A new instance of the term such that newTermInstance.equals(original) returns true.
+     * @see Term
+     */
+    fromTerm(original: InQuad): OutQuad;
+    fromTerm<T extends Term>(original: T): T;
+
+    /**
+     * @param original The original quad.
+     * @return A new instance of the quad such that newQuadInstance.equals(original) returns true.
+     * @see Quad
+     */
+    fromQuad(original: InQuad): OutQuad;
 }

rdf-js-tests.ts

@@ -19,7 +19,7 @@
 
     const namedNodeConstant: NamedNode<'http://example.org'> = <any> {};
     const constantIri: 'http://example.org' = namedNodeConstant.value;
     // @ts-expect-error
     const otherConstantIri: 'http://not-example.org' = namedNodeConstant.value;
     // @ts-expect-error
     const otherNamedNodeConstant: NamedNode<'http://not-example.org'> = namedNodeConstant;
@@ -84,6 +84,34 @@
 
     const variable: Variable = dataFactory.variable ? dataFactory.variable('v1') : <any> {};
 
+    const defaultGraph: DefaultGraph = dataFactory.defaultGraph();
+
+    type NamedNodeExt = NamedNode & { someProp: string };
+    const term1: NamedNode = dataFactory.fromTerm(<NamedNodeExt>{});
+    const term1ext: NamedNodeExt = dataFactory.fromTerm(<NamedNodeExt>{});
+    type BlankNodeExt = BlankNode & { someProp: string };
+    const term2: BlankNode = dataFactory.fromTerm(<BlankNodeExt>{});
+    const term2ext: BlankNodeExt = dataFactory.fromTerm(<BlankNodeExt>{});
+    type LiteralExt = Literal & { someProp: string };
+    const term3: Literal = dataFactory.fromTerm(<LiteralExt>{});
+    const term3ext: LiteralExt = dataFactory.fromTerm(<LiteralExt>{});
+    type VariableExt = Variable & { someProp: string };
+    const term4: Variable = dataFactory.fromTerm(<VariableExt> {});
+    const term4ext: VariableExt = dataFactory.fromTerm(<VariableExt> {});
+    type DefaultGraphExt = DefaultGraph & { someProp: string };
+    const term5: DefaultGraph = dataFactory.fromTerm(<DefaultGraphExt>{});
+    const term5ext: DefaultGraphExt = dataFactory.fromTerm(<DefaultGraphExt>{});
+    type OutQuadExt = Quad & { someProp: string };
+    const term6: Quad = dataFactory.fromTerm(<OutQuadExt>{});
+    const term6ext: OutQuadExt = dataFactory.fromTerm<OutQuadExt>(<OutQuadExt>{});
+
+    const quadFromQuad: Term = dataFactory.fromQuad(dataFactory.quad(
+        dataFactory.namedNode("x"),
+        dataFactory.namedNode("y"),
+        dataFactory.literal(""),
+        dataFactory.defaultGraph()
+    ));
+
     const term: NamedNode = <any> {};
     interface QuadBnode extends BaseQuad {
       subject: Term;
@@ -119,6 +147,8 @@
         const equalToSelf: boolean = quadBobAge2.equals(quadBobAge);
         const notEqualToOtherType: boolean = quadBobAge2.equals(dataFactory.namedNode('ex:something:else'));
     }
+
+    const quadTerm: Quad = dataFactory.fromTerm(quadBobAge);
 }
 
 function test_datafactory_star_basequad() {
@@ -143,6 +173,26 @@
         const equalToSelf: boolean = quadBobAge2.equals(quadBobAge);
         const notEqualToOtherType: boolean = quadBobAge2.equals(dataFactory.namedNode('ex:something:else'));
     }
+
+    const datafactoryBaseQuadToQuad: DataFactory<BaseQuad, Quad> = <any> {};
+
+    const quadToBaseQuad1: BaseQuad = datafactoryBaseQuadToQuad.fromTerm(quadBobAge);
+
+    const baseQuadTerm: BaseQuad = dataFactory.fromTerm(quadBobAge);
+
+    const baseQuad: BaseQuad = dataFactory.fromQuad(quadBobAge);
+
+    // Test with regular Quad
+    const quadDataFactory: DataFactory<Quad> = <any> {};
+
+    const regularQuadBobAge: Quad = quadDataFactory.quad(
+        dataFactory.namedNode('ex:bob'),
+        dataFactory.namedNode('ex:age'),
+        dataFactory.literal('23'),
+    );
+
+    const quadTerm: Quad = quadDataFactory.fromTerm(regularQuadBobAge);
+    const quadTerm2: Quad = datafactoryBaseQuadToQuad.fromTerm<Quad>(regularQuadBobAge);
 }
 
 function test_stream() {