-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update node-hid dependency to version 0.7.4 #81
base: master
Are you sure you want to change the base?
Conversation
Sorry, I forgot to mention this is to fix an issue on Linux when you are building node-hid from source. |
This pull would help me |
@rdepena Could you take a look at this? Currently this is causing the module to break for some users, and the PR only contains a simple version bump. |
@@ -1,10 +1,10 @@ | |||
{ | |||
"name": "dualshock-controller", | |||
"version": "1.1.1", | |||
"version": "1.1.2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm pretty sure that this shouldn't be a part of the PR, as usually maintainers bump the version of the module themselves in a separate commit.
@rdepena Bump |
@rdepena Bump :) |
If I understand correctly the version of node-hid included in the project is causing some error with new versions of NodeJS.
This pull request is to update node-hid to the latest (0.7.4).
I also updated the package version number to 1.1.2.