Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build fails after upgrading to v2 #167

Closed
fabioDMFerreira opened this issue Jan 2, 2019 · 1 comment
Closed

Build fails after upgrading to v2 #167

fabioDMFerreira opened this issue Jan 2, 2019 · 1 comment

Comments

@fabioDMFerreira
Copy link

Describe the bug

After upgrading react trello from version 1 to version 2 I started to get the next error on building my application (bootstrapped by create-react-app).

Creating an optimized production build...
Failed to compile.

Failed to minify the code from this file:

        ./node_modules/react-trello/dist/styles/Base.js:12

Read more here: http://bit.ly/2tRViJ9

Comment uglify plugin in webpack configuration script fixes the problem, but I want to keep the bundle as small as possible. It may be related with modern javascript features that were introduced in this new react-trello version as create-react-app documentation suggests.
https://facebook.github.io/create-react-app/docs/troubleshooting#npm-run-build-fails-to-minify

Also tried other solutions:
ccxt/ccxt#299
mishoo/UglifyJS#2011

The problem seems solved in the new create-react-app version. It uses webpack 4 and uglify was deprecated.

To Reproduce
Steps to reproduce the behavior:

  1. Download repository from next origin:
    https://github.com/fabioDMFerreira/react-trello-webpack-3
  2. Run npm run build

Expected behavior
Build bundle without problems.

rcdexta added a commit that referenced this issue Jan 13, 2019
@rcdexta
Copy link
Owner

rcdexta commented Jan 13, 2019

should be fixed in v2.0.9

@rcdexta rcdexta closed this as completed Jan 13, 2019
reactexp925 added a commit to reactexp925/react-trello that referenced this issue Dec 5, 2019
pikachunerdy added a commit to pikachunerdy/react-trello that referenced this issue Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants