Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CAPI-420: Initial OAS3 migration #3

Merged
merged 6 commits into from
Jun 1, 2020
Merged

CAPI-420: Initial OAS3 migration #3

merged 6 commits into from
Jun 1, 2020

Conversation

kehitt
Copy link

@kehitt kehitt commented May 7, 2020

No description provided.

@kehitt kehitt requested a review from a team as a code owner May 7, 2020 12:24
@kehitt kehitt self-assigned this May 7, 2020
@kehitt kehitt changed the title CAPI-415: Initial OAS3 migration CAPI-420: Initial OAS3 migration May 19, 2020
keynslug
keynslug reviewed May 25, 2020
View reviewed changes
.redocly.yaml Outdated Show resolved Hide resolved
.redocly.yaml Show resolved Hide resolved
openapi/docs/api_description.md Outdated Show resolved Hide resolved
openapi/docs/api_description.md Outdated Show resolved Hide resolved
openapi/openapi.yaml Outdated Show resolved Hide resolved
openapi/openapi.yaml Outdated Show resolved Hide resolved
keynslug
keynslug approved these changes May 26, 2020
View reviewed changes
Copy link

@keynslug keynslug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

По плану разработки разве что остались вопросы:

  • Имеем ли право мержить в мастер, пока не убедились, что бэкенд остался совместимым?
  • И не нужно ли ещё команду rbkmoney/frontend попросить ревью провести?

@kehitt
Copy link
Author

kehitt commented May 26, 2020

@keynslug

  • Да, наверное пока в эпиках будем, как build-image.
  • Можно и пригласить, почему бы и нет.

@keynslug keynslug requested a review from a team May 26, 2020 16:29
@keynslug
Copy link

keynslug commented Jun 1, 2020

@kehitt Тогда давай на epic-ветку направим этот PR.

KeinAsylum
KeinAsylum reviewed Jun 1, 2020
View reviewed changes
Copy link

@KeinAsylum KeinAsylum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

С нашей стороны ок

@kehitt kehitt changed the base branch from master to epic/oas3_migration June 1, 2020 14:01
@kehitt kehitt merged commit a413f7c into epic/oas3_migration Jun 1, 2020
@kehitt kehitt deleted the ft/oas3_migration branch June 1, 2020 14:02
@keynslug keynslug mentioned this pull request Sep 29, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KeinAsylum KeinAsylum KeinAsylum left review comments

@keynslug keynslug keynslug approved these changes

Assignees

@kehitt kehitt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kehitt @keynslug @KeinAsylum