Switch to EA builds from graalvm/graal-languages-ea-builds for truffleruby+graalvm-dev #2356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
eregon
commented
Mar 18, 2024
eregon
commented
- See https://github.com/graalvm/graal-languages-ea-builds
- These are based on Oracle GraalVM.
- cc @nirvdrum
…eruby+graalvm-dev * See https://github.com/graalvm/graal-languages-ea-builds * These builds are based on Oracle GraalVM.
eregon
commented
Mar 18, 2024
Comment on lines
+21
to
+24
| pushd "$BUILD_PATH" >/dev/null | ||
| http get $url url.txt | ||
| url=$(<url.txt) | ||
| popd |
There was a problem hiding this comment.
The pushd is needed because aria2c -o /absolute/path doesn't work, it actually writes in /cwd//absolute/path which is the same as /cwd/absolute/path.
It would be tempting to just use curl to avoid the extra file, but that doesn't work on systems without curl.
There was a problem hiding this comment.
Yeah, the ruby-build script only ever calls http with a path-less filename so it just downloads to the CWD and eventually removes the file.
I worked around this once by just using a tempfile: Shopify/ruby-definitions#36
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.