Add tests for functionality related to linking to OpenSSL #2276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Now only generates a `configure` script if explicitly specified - Add ability to add arbitrary files to the tarball - Cache most common tarballs in fixtures directory to speed up tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for OpenSSL linking improvements in #2275, this adds tests for the current
needs_openssl_*functionality.The tests are emulating a macOS platform because we have no facilities to stub out system OpenSSL presence or version in the test suite, which would be necessary for making proper Linux tests.
As a bonus, the
cached_tarballtest helper is now vastly improved.