-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for callback url #37
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As mentioned in the magento callback_url PR, the failure modes need to be handled in the callback URL, otherwise this breaks.
f07e1cf
to
4a98818
Compare
127986f
to
cce1f68
Compare
Pushed a fix for a variable assignment issue (callbackUrl), but there are still a few errors.
Please ensure that you have wordpress error display enabled. This is how my <?php
define( 'WP_DEBUG', true );
// Enable Debug logging to the /wp-content/debug.log file
define( 'WP_DEBUG_LOG', true );
// Disable display of errors and warnings
define( 'WP_DEBUG_DISPLAY', true );
@ini_set( 'display_errors', 0 );
// Use dev versions of core JS and CSS files (only needed if you are modifying these core files)
define( 'SCRIPT_DEBUG', true ); |
razorpay-payments.php
Outdated
} | ||
} | ||
|
||
protected function handleErrorCase($order_id, & $order) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
take only order here as well, use the getOrderId() I just committed
razorpay-payments.php
Outdated
$order->add_order_note("Payment Failed. Please check Razorpay Dashboard. <br/> Razorpay Id: " . $attributes[self::RAZORPAY_PAYMENT_ID]); | ||
$order->update_status('failed'); | ||
} | ||
$this->updateOrder($order, $success, $razorpayPaymentId); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updateOrder should also be called with success=false for the error case?
2c92b07
to
749b8b7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do a squash merge post testing.
2c9db8d
to
5a00aba
Compare
Added support for callback url.