setup for .net47 #81
Merged
setup for .net47 #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ra0van
reviewed
Aug 22, 2023
Razorpay.nuspec
Outdated
| @@ -15,10 +15,12 @@ | |||
| <tags>Razorpay</tags> | |||
| <dependencies> | |||
| <dependency id="Newtonsoft.Json" version="11.0.2" /> | |||
| <dependency id="Newtonsoft.Json" version="13.0.3" /> | |||
There was a problem hiding this comment.
I believe there is a better way for handling multiple versions of the same assembly.
Refer this - https://learn.microsoft.com/en-us/dotnet/framework/configure-apps/redirect-assembly-versions
There was a problem hiding this comment.
Added
<dependency id="Newtonsoft.Json" version="[11.0.2,13.0.3)" />
net47/Properties/AssemblyInfo.cs
Outdated
| [assembly: AssemblyConfiguration("")] | ||
| [assembly: AssemblyCompany("Razorpay Software Private Limited")] | ||
| [assembly: AssemblyProduct("Razorpay.API")] | ||
| [assembly: AssemblyCopyright("Copyright © 2015")] |
There was a problem hiding this comment.
CopyRight should have current year also right?
There was a problem hiding this comment.
Also added in nuspec file
| <Target Name="AfterBuild"> | ||
| </Target> | ||
| --> | ||
| </Project> |
net47/packages.config
Outdated
| <?xml version="1.0" encoding="utf-8"?> | ||
| <packages> | ||
| <package id="Newtonsoft.Json" version="13.0.3" targetFramework="net47" /> | ||
| </packages> |
ra0van
reviewed
Sep 12, 2023
Razorpay.nuspec
Outdated
| @@ -14,11 +14,12 @@ | |||
| <copyright>Copyright 2015</copyright> | |||
| <tags>Razorpay</tags> | |||
| <dependencies> | |||
| <dependency id="Newtonsoft.Json" version="11.0.2" /> | |||
| <dependency id="Newtonsoft.Json" version="[11.0.2,13.0.3)" /> | |||
There was a problem hiding this comment.
closing Brackets are not same. Please test
There was a problem hiding this comment.
using single version instead of multiple , also checked the v13.0.3 is compatible for old .net version as well.
ra0van
approved these changes
Sep 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Support for .net 47