-
Notifications
You must be signed in to change notification settings - Fork 4
Conversation
e768def
to
d5cfec7
Compare
d5cfec7
to
73403c1
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Codecov Report
@@ Coverage Diff @@
## rzp_main #42 +/- ##
===========================================
Coverage ? 79.60%
Complexity ? 1306
===========================================
Files ? 117
Lines ? 5223
Branches ? 474
===========================================
Hits ? 4158
Misses ? 853
Partials ? 212
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TriptiTripathi1234
Can you change branch name in pr-test.yml
and pr-build.yml
to rzp_main
?
.github/codecov.yml
Outdated
@@ -0,0 +1,2 @@ | |||
codecov: | |||
branch: rzp_main # Default branch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is not required, if using codecov/codecov-action@v2 in pr-test.yml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For me, codecov was taking default branch as main
for some reason, even though we had rzp_main
.
Had to put this to have it in sync.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
before this change, it was failing and report was not added in PR comment. Check out here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think pr-test was running on main branch, did you try rzp_main in pr-test.yml?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes still same issue
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
after merge, the code will be present in rzp_main, then i think it will work as expected
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Unit Test Results 75 files 75 suites 1m 2s ⏱️ Results for commit 1e6a206. |
No description provided.