This repository has been archived by the owner on Nov 14, 2023. It is now read-only.
forked from hypertrace/hypertrace-ingester
-
Notifications
You must be signed in to change notification settings - Fork 4
Github action for release having docker Image with Tag as version number #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TriptiTripathi1234
force-pushed
the
create_github_job_for_release
branch
from
July 19, 2022 11:17
696e6e8
to
4e9d224
Compare
TriptiTripathi1234
force-pushed
the
create_github_job_for_release
branch
from
July 21, 2022 04:45
4e9d224
to
6ae5ab9
Compare
Harnoor-se7en
suggested changes
Jul 21, 2022
hypertrace-metrics-processor/hypertrace-metrics-processor/build.gradle.kts
Show resolved
Hide resolved
hypertrace-metrics-generator/hypertrace-metrics-generator/build.gradle.kts
Show resolved
Hide resolved
hypertrace-metrics-exporter/hypertrace-metrics-exporter/build.gradle.kts
Show resolved
Hide resolved
Harnoor-se7en
suggested changes
Jul 21, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Github actions are failing. Please check the errors.
The error says to run ./gradlew spotless checks for code format fix.
TriptiTripathi1234
force-pushed
the
create_github_job_for_release
branch
5 times, most recently
from
July 23, 2022 13:43
a5cc174
to
e8e3c5a
Compare
TriptiTripathi1234
force-pushed
the
create_github_job_for_release
branch
from
July 23, 2022 14:01
e8e3c5a
to
18316ec
Compare
/release v0.6.40-0.1.0-beta.1 |
Approving for now. Please revert the PR if the release versioning doesn't work after merging in the default branch. |
Harnoor-se7en
approved these changes
Jul 25, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we create a PR and write a comment as "/release {version_number}"
This triggers a github action that will build docker images with above version as tag.
Once the PR is merged, we can create a release with above tag(version)