add apollo graphql to graphql branch (#159) #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* graphql * update * update * update * update * update * update per review comments * update * update * update apollo and graphql package vesions * update * update * update * update * update * update
yingwang-us
changed the title
mckaymic
suggested changes
Feb 26, 2020
|
temporarily turned off vulnerability 1217 for audit since it does not impact prod image. Still waiting kevva/decompress#71 to be fixed. |
mckaymic
reviewed
Mar 4, 2020
mckaymic
approved these changes
Mar 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following changes are made based on Mike's code review comments.
Add ENABLE_GRAPHQL environment variable , default is false. see here and here
Add req_id to graphql context, which is then used by logger to print debug information with the req_id. see here for setting and here for example how to use. Note, for web socket connections, the req_id on the context is the original http upgrade request
req.id.Add apollo's bunyan config here . This is because graphql has common url and we need to turn on body log, so we could know what graphql api is called. Also include some optimization to disable debug logs for playground ping requests.
Add identifier in user schema and make email as optional. It is because some tokens might not be associated with any email, e.g. a token generated from service-id api key.
other minor changes mentioned in Mike's code review under
graphql (see the latest in graphql branch or this PR #173) #142