29-make-person-view-filterable-and-sortable #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces the `PersonSlotFilterComponent` and `PersonSortButtonsComponent` to enable reuse.
Removed manual sorting and filtering logic in the GroupingComponent, shifting to reusable components for sorting buttons and slot filters. Updated the PersonService to allow sorting and filtering.
Introduced `PersonSearchComponent` to enable users to search for persons within the list. Updated `PersonListComponent` to filter results based on search input.
Renamed PersonSearchComponent and associated files to SearchFieldComponent to reflect broader usage.
Integrate the SearchFieldComponent and implement dynamic person filtering based on the search term in the grouping component.
Replaced local search logic in person components with centralized filtering using slot and name filters in the PersonService. Removed redundant search functionality and dependencies to streamline. Updated components to reflect the new filtering system.
Removed unused OnInit lifecycle and updated person filter handling for clarity. Added a new template to display messages for unmatched name filters, improving user feedback.
raywo
added a commit
that referenced
this pull request
Jan 13, 2025
29-make-person-view-filterable-and-sortable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.