Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(policy): return error when approvers evaluation returns nil #387

Merged
merged 8 commits into from
Jun 14, 2023
Merged

fix(policy): return error when approvers evaluation returns nil #387

merged 8 commits into from
Jun 14, 2023

Conversation

Chief-Rishab
Copy link
Member

No description provided.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 5265931860

  • 52 of 70 (74.29%) changed or added relevant lines in 9 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 75.966%
Changes Missing Coverage Covered Lines Changed/Added Lines %
core/provider/service.go 0 1 0.0%
api/handler/v1beta1/appeal.go 5 9 55.56%
core/appeal/service.go 31 37 83.78%
plugins/providers/metabase/client.go 3 10 30.0%
Totals Coverage Status
Change from base Build 5263088461: 0.03%
Covered Lines: 8136
Relevant Lines: 10710
💛 - Coveralls

@ravisuhag ravisuhag merged commit 237118d into main Jun 14, 2023
@ravisuhag ravisuhag deleted the fix/policy branch June 14, 2023 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ravisuhag ravisuhag Awaiting requested review from ravisuhag ravisuhag is a code owner

@rahmatrhd rahmatrhd Awaiting requested review from rahmatrhd rahmatrhd is a code owner

@AkarshSatija AkarshSatija Awaiting requested review from AkarshSatija AkarshSatija is a code owner

@mabdh mabdh Awaiting requested review from mabdh mabdh is a code owner

@bsushmith bsushmith Awaiting requested review from bsushmith bsushmith is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Chief-Rishab @coveralls @ravisuhag