Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: http code if user already member in invite #783

Merged
merged 1 commit into from
Sep 25, 2024
Merged

fix: http code if user already member in invite #783

merged 1 commit into from
Sep 25, 2024

Conversation

kushsharma
Copy link
Member

Service won't return 5xx if a user is already a member of organization while creating the invite.

@vercel Vercel
Copy link

vercel bot commented Sep 23, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
frontier ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 24, 2024 4:55am

@kushsharma kushsharma marked this pull request as ready for review September 23, 2024 13:38
@coveralls
Copy link

coveralls commented Sep 23, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11007254020

Details

  • 3 of 630 (0.48%) changed or added relevant lines in 9 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.003%) to 9.666%
Changes Missing Coverage Covered Lines Changed/Added Lines %
core/invitation/service.go 1 2 50.0%
internal/api/v1beta1/invitations.go 2 4 50.0%
core/invitation/mocks/policy_service.go 0 46 0.0%
core/invitation/mocks/user_service.go 0 46 0.0%
core/invitation/mocks/preferences_service.go 0 47 0.0%
core/invitation/mocks/relation_service.go 0 74 0.0%
core/invitation/mocks/group_service.go 0 112 0.0%
core/invitation/mocks/organization_service.go 0 112 0.0%
core/invitation/mocks/repository.go 0 187 0.0%
Totals Coverage Status
Change from base Build 10957009003: -0.003%
Covered Lines: 10935
Relevant Lines: 113132
💛 - Coveralls

@kushsharma
fix: http code if user already member in invite
e80b774 
Service won't return 5xx if a user is already a member of
organization while creating the invite.

Signed-off-by: Kush Sharma <thekushsharma@gmail.com>
@kushsharma kushsharma merged commit 03b036e into main Sep 25, 2024
7 checks passed
@kushsharma kushsharma deleted the invite-already-user-err branch September 25, 2024 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anujk14 anujk14 anujk14 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kushsharma @coveralls @anujk14