Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add filter for providerID on subscription repo, and remove unnecessary invoice event in syncer #757

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

anujk14
Copy link
Contributor

@anujk14 anujk14 commented Aug 29, 2024

This PR solves a couple of issues:

  1. We used to sync only the first subscription in our repository because the subscription repository did not use the providerID passed to it as input. This PR fixes that.
  2. The event for "invoice created" cannot use the same provider id that is passed since the provider id there refers to invoice id, whereas the code written assumes that the id passed is a customer id. Due to issue (1), the "invoice created" event was anyway not getting triggered

Copy link

vercel bot commented Aug 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
frontier ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 29, 2024 10:08am

@coveralls
Copy link

Pull Request Test Coverage Report for Build 10613008149

Details

  • 0 of 5 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.001%) to 9.528%

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/store/postgres/billing_subscription_repository.go 0 5 0.0%
Totals Coverage Status
Change from base Build 10610777620: -0.001%
Covered Lines: 10550
Relevant Lines: 110723

💛 - Coveralls

@kushsharma kushsharma merged commit 9f5a301 into main Aug 29, 2024
7 checks passed
@kushsharma kushsharma deleted the invoice_sync_fix branch August 29, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants