feat (members): Use new API to add user to project instead of creating policy directly #733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Pull Request Test Coverage Report for Build 10576355263Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ID-449
Problem statement:
Call an abstraction API for addTeam and addMember instead of calling the policy creation API directly as it could be a security issue.
Solution:
Using
V1Beta1CreatePolicyForProjectBodyinstead offrontierServiceCreatePolicy.New API https://frontier-raystack.vercel.app/apis/frontier-service-create-policy-for-project
Note:
frontierServiceCreatePolicyAPI is being used in many other places within functions likeupdateRole,addGroupTeamPolicy,addTeam.Above PR only contains changes for
addMemberandaddTeam.