Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: increase number of histogram buckets for syncer latencies #709

Merged
merged 1 commit into from
Aug 5, 2024

Conversation

kushsharma
Copy link
Member

  • newly added buckets in seconds
{.005, .01, .025, .05, .1, .25, .5, 1, 2.5, 5, 10, 20, 40, 90, 180}
  • context cancellation will stop syncing early instead of continuing to iterate over items
  • tests for policy service

- newly added buckets
```
{.005, .01, .025, .05, .1, .25, .5, 1, 2.5, 5, 10, 20, 40, 90, 180}
```
- context cancellation will stop syncing early instead of continue
to iterate over items
- tests for policy service

Signed-off-by: Kush Sharma <thekushsharma@gmail.com>
Copy link

vercel bot commented Aug 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
frontier ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 2, 2024 1:25pm

@coveralls
Copy link

Pull Request Test Coverage Report for Build 10216392616

Details

  • 0 of 515 (0.0%) changed or added relevant lines in 10 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.04%) to 9.506%

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/metrics/db.go 0 1 0.0%
internal/metrics/stripe.go 0 2 0.0%
billing/customer/service.go 0 3 0.0%
billing/invoice/service.go 0 3 0.0%
billing/checkout/service.go 0 6 0.0%
billing/subscription/service.go 0 6 0.0%
internal/api/v1beta1/mocks/checkout_service.go 0 37 0.0%
core/policy/mocks/relation_service.go 0 74 0.0%
core/policy/mocks/role_service.go 0 84 0.0%
core/policy/mocks/repository.go 0 299 0.0%
Totals Coverage Status
Change from base Build 10191907741: 0.04%
Covered Lines: 10358
Relevant Lines: 108961

💛 - Coveralls

@kushsharma kushsharma merged commit 62063de into main Aug 5, 2024
7 checks passed
@kushsharma kushsharma deleted the metrics-histogram-buckets branch August 5, 2024 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants