Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use crypto/rand package to generate otp chars #608

Merged
merged 1 commit into from
May 8, 2024

Conversation

kushsharma
Copy link
Member

  • added documentation on how to use webhooks

Copy link

vercel bot commented May 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
frontier ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 8, 2024 5:13am

@kushsharma kushsharma marked this pull request as ready for review May 7, 2024 14:33
@coveralls
Copy link

coveralls commented May 7, 2024

Pull Request Test Coverage Report for Build 8996623019

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 8 of 22 (36.36%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 9.422%

Changes Missing Coverage Covered Lines Changed/Added Lines %
core/authenticate/strategy/mail_link.go 0 1 0.0%
pkg/crypt/random.go 7 8 87.5%
core/event/processor.go 0 6 0.0%
core/invitation/service.go 0 6 0.0%
Totals Coverage Status
Change from base Build 8980510404: 0.0%
Covered Lines: 9560
Relevant Lines: 101469

💛 - Coveralls

- added documentation on how to use webhooks
- added documentation on how tokens work

Signed-off-by: Kush Sharma <thekushsharma@gmail.com>
@kushsharma kushsharma merged commit 5224ebc into main May 8, 2024
5 of 6 checks passed
@kushsharma kushsharma deleted the fix-mailotp-randomness branch May 8, 2024 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants