Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgraded authz functionality #185

Merged
merged 7 commits into from
Nov 28, 2022
Merged

feat: upgraded authz functionality #185

merged 7 commits into from
Nov 28, 2022

Conversation

krtkvrm
Copy link
Member

@krtkvrm krtkvrm commented Nov 17, 2022

We only have authz check for Resource Group Namespaces

@@ -13,8 +13,8 @@ var DefinitionProject = Namespace{
}

var DefinitionTeam = Namespace{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SHouldn't this be DefinitionGroup ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can do this in another PR

@krtkvrm krtkvrm merged commit c85a53b into rc/0.5.0 Nov 28, 2022
@krtkvrm krtkvrm deleted the issue/180 branch November 28, 2022 05:29
ravisuhag pushed a commit that referenced this pull request Jan 30, 2023
* feat: add updated schema

* feat: add updated proto

* feat: update CheckAuthz Service

* feat: refactor CheckAuthz Service

* feat: change type of status from string to bool

* feat: authz middleware

* fix: lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants