-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: config management and error handling #155
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 2887124987
💛 - Coveralls |
mabdh
force-pushed
the
cli-config-improvement
branch
from
August 16, 2022 05:39
39a9053
to
ac43204
Compare
mabdh
force-pushed
the
cli-config-improvement
branch
from
August 18, 2022 04:25
5d0ff0e
to
57977d9
Compare
mabdh
force-pushed
the
cli-config-improvement
branch
from
August 18, 2022 04:29
57977d9
to
0bb6b7d
Compare
mabdh
changed the title
feat: config management and error handling
feat!: config management and error handling
Aug 18, 2022
ravisuhag
reviewed
Aug 18, 2022
ravisuhag
reviewed
Aug 18, 2022
ravisuhag
reviewed
Aug 18, 2022
ravisuhag
approved these changes
Aug 19, 2022
@mabdh Let's also move the shield sample config file to the config package itself and call it |
ravisuhag
reviewed
Aug 19, 2022
ravisuhag
reviewed
Aug 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tasks
Error handling in client config
The existence of
$ODPF_CONFIG_DIR/shield.yaml
need a config or flag --host
--host
would pass--host
would return--header
is required (we mark this as required)--host
and--header
would passSome changes in cli