-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: prevent proxy context cancelled #144
Conversation
internal/proxy/roundtripper.go
Outdated
} | ||
|
||
func (c Context) Deadline() (time.Time, bool) { | ||
return time.Time{}, false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
doing
t, b := c.ctx.Deadline()
return t, b
was throwing stack overflow
Pull Request Test Coverage Report for Build 2837820768
💛 - Coveralls |
internal/proxy/roundtripper.go
Outdated
return nil | ||
} | ||
|
||
func (c Context) Err() error { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can also only prevent "Context Cancelled" errors, but let others to return
internal/proxy/roundtripper.go
Outdated
return time.Time{}, false | ||
} | ||
|
||
func (c Context) Done() <-chan struct{} { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can also log when done != nil
@krtkvrm for the PR prefix, is it a also, should we create a new issue and link the issue to this PR? |
Expectation