Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove orgId dependency in authz #132

Merged
merged 12 commits into from
Aug 9, 2022

Conversation

niharbansal02
Copy link
Member

@niharbansal02 niharbansal02 commented Jul 26, 2022

This removes the dependency of the organization ID to be passed in the request.
A project can belong only to one organization, so the organization is extracted using the Project ID from the request.

This closes #104

@ravisuhag ravisuhag requested a review from krtkvrm July 29, 2022 06:02
@AkarshSatija AkarshSatija self-requested a review August 1, 2022 10:28
@AkarshSatija
Copy link
Member

Can we mention all the APIs being affected by this?

@AkarshSatija AkarshSatija linked an issue Aug 1, 2022 that may be closed by this pull request
@mabdh mabdh changed the title feat: remove orgId dependancy in authz feat: remove orgId dependency in authz Aug 2, 2022
internal/proxy/hook/authz/authz.go Outdated Show resolved Hide resolved
internal/proxy/hook/authz/authz.go Outdated Show resolved Hide resolved
internal/proxy/hook/authz/authz.go Outdated Show resolved Hide resolved
@coveralls
Copy link

Pull Request Test Coverage Report for Build 2815924228

  • 14 of 20 (70.0%) changed or added relevant lines in 1 file are covered.
  • 7 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.1%) to 50.852%

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/proxy/hook/authz/authz.go 14 20 70.0%
Files with Coverage Reduction New Missed Lines %
internal/proxy/hook/authz/authz.go 7 19.91%
Totals Coverage Status
Change from base Build 2799222616: -0.1%
Covered Lines: 2329
Relevant Lines: 4580

💛 - Coveralls

@AkarshSatija AkarshSatija self-requested a review August 9, 2022 07:32
@ravisuhag ravisuhag merged commit d9f01fb into raystack:main Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using ProjectID to fetch OrgID in Hook and Proxy
5 participants