Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move server, store, hook, middleware to internal package #130

Merged
merged 4 commits into from
Jul 26, 2022

Conversation

mabdh
Copy link
Member

@mabdh mabdh commented Jul 25, 2022

Summary

  • Move hook and middleware package to proxy package and move proxy package to internal package
  • Move server and store to internal package
  • Move api/handler to internal as it is only being used by internal packages
  • Do component creation only on cmd level
  • Remove unnecessary log fatal from the main code, log fatal and panic should only be allowed to be executed in cmd, return error instead
  • Decouple api.Dependencies from v1beta1
  • Move server and proxy serving to server and proxy package
  • Fix graceful shutdown of all storages, proxies, and server
  • Move resources and rules config to config folder
  • Move logger and grpc_interceptor to pkg
  • Rename Id to ID

@mabdh mabdh marked this pull request as ready for review July 25, 2022 09:26
@mabdh
Copy link
Member Author

mabdh commented Jul 25, 2022

This will also close bug in #129

@ravisuhag ravisuhag linked an issue Jul 26, 2022 that may be closed by this pull request
@ravisuhag ravisuhag merged commit 2c7c4e5 into main Jul 26, 2022
@ravisuhag ravisuhag deleted the refactor-server-store branch July 26, 2022 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants