Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add grpc-gateway #97

Merged
merged 2 commits into from
Mar 21, 2022
Merged

feat: add grpc-gateway #97

merged 2 commits into from
Mar 21, 2022

Conversation

mabdh
Copy link
Member

@mabdh mabdh commented Mar 18, 2022

No description provided.

@mabdh mabdh requested a review from StewartJingga March 18, 2022 13:09
@mabdh mabdh linked an issue Mar 18, 2022 that may be closed by this pull request
feat: grpc interface #93
Closed
@mabdh mabdh removed a link to an issue Mar 18, 2022
feat: grpc interface #93
Closed
@mabdh mabdh mentioned this pull request Mar 18, 2022
Closed
@mabdh mabdh self-assigned this Mar 18, 2022
@mabdh mabdh added the enhancement New feature or request label Mar 18, 2022
@mabdh mabdh requested a review from rahmatrhd March 18, 2022 13:15
@mabdh mabdh marked this pull request as ready for review March 18, 2022 13:15
@mabdh mabdh requested a review from ravisuhag March 18, 2022 13:16
StewartJingga
StewartJingga reviewed Mar 21, 2022
View reviewed changes
@StewartJingga
Copy link
Contributor

StewartJingga commented Mar 21, 2022 •
edited
Loading

Need help updating config.yaml.example as well for the new config GRPC_SERVER_PORT. 🙏
Or is it temporary?

@StewartJingga StewartJingga self-requested a review March 21, 2022 10:05
@mabdh
Copy link
Member Author

mabdh commented Mar 21, 2022 •
edited
Loading

@StewartJingga it is for temporary stew.
I have added it.

@mabdh mabdh merged commit f2a14a4 into main Mar 21, 2022
@mabdh mabdh deleted the grpc-interface branch March 21, 2022 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rahmatrhd rahmatrhd Awaiting requested review from rahmatrhd

@ravisuhag ravisuhag Awaiting requested review from ravisuhag

@StewartJingga StewartJingga Awaiting requested review from StewartJingga

Assignees

@mabdh mabdh

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mabdh @StewartJingga