feat(star): could accept email in /users/{id}/starred #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mabdh
force-pushed
the
users-api-accept-email
branch
from
bd11e45 to
af67536
Compare
rahmatrhd
reviewed
Feb 22, 2022
star/star.go
Outdated
Comment on lines
23
to
24
| GetAllAssetsByUserID(ctx context.Context, cfg Config, userID string) ([]asset.Asset, error) | ||
| GetAllAssetsByUserEmail(ctx context.Context, cfg Config, userID string) ([]asset.Asset, error) |
There was a problem hiding this comment.
type filter struct {
id string
email string
}
type Repository interface {
...
GetAllAssets(ctx context.Context, cfg Config, filter filter) ([]asset.Asset, error)
...
}have we looked into this^ approach?
There was a problem hiding this comment.
These 2 have different sql query,
GetAllAssetsByUserEmail joined 3 tables
GetAllAssetsByUserID joined 2 tables
I am afraid it will just make it more complex
rahmatrhd
approved these changes
Feb 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.