Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update api to be user-aware #70

Merged
merged 2 commits into from
Feb 3, 2022
Merged

feat: update api to be user-aware #70

merged 2 commits into from
Feb 3, 2022

Conversation

mabdh
Copy link
Member

@mabdh mabdh commented Jan 25, 2022

Currently require all APIs in v1beta1 to have identity headers (configurable via config)

  • Columbus-User-Email ex: user@odpf.io

v1 API (that we want to remove) won't need that header

@mabdh mabdh linked an issue Jan 25, 2022 that may be closed by this pull request
@mabdh mabdh force-pushed the api-user-aware branch 3 times, most recently from 4a9c90f to 51ff646 Compare January 25, 2022 10:11
@mabdh mabdh added the enhancement New feature or request label Jan 25, 2022
@mabdh mabdh force-pushed the api-user-aware branch 2 times, most recently from 93de6be to c95ee22 Compare January 26, 2022 02:50
@mabdh mabdh self-assigned this Jan 26, 2022
@mabdh mabdh force-pushed the api-user-aware branch 2 times, most recently from 0b0b923 to 8e58d7f Compare January 26, 2022 07:57
@mabdh mabdh mentioned this pull request Jan 26, 2022
@mabdh mabdh merged commit 730c813 into main Feb 3, 2022
@mabdh mabdh deleted the api-user-aware branch February 3, 2022 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(api): update to support user aware information
3 participants