fix: remove build action workflow #53
Conversation
.github/workflows/build.yml
Outdated
| on: | ||
| push: | ||
| tags: | ||
| - "v*.*.*" | ||
| branches: |
There was a problem hiding this comment.
@StewartJingga Any reason we want to release docker image on every commit?
There was a problem hiding this comment.
Was just letting people to get the latest update/fix on main branch only.
Right now in our current setup latest tag in docker means latest main branch. unless we want to change it to mean latest tag.
There was a problem hiding this comment.
I think we should point the latest docker tag to the latest stable release and we can push a nightly build with a different tag for the main branch build. WDYT?
There was a problem hiding this comment.
sounds good to me. after reading a few articles about latest tag, it seems like it is to be avoided if possible.
latest is basically just another tag that is being added if there is no tag presents.
So maybe we could just remove this build action unless we want a special tag for this main branch called main perhaps? wdyt?
There was a problem hiding this comment.
For now, I think we can remove it. If later we decide to publish the nightly build we can include it.
There was a problem hiding this comment.
@ravisuhag removed 🙏
StewartJingga
changed the title
Fix github's
buildaction workflow due to code changes made to cater newreleaseaction workflow.