Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(types): clean up dynamic types #51

Merged
merged 11 commits into from
Jan 11, 2022
Merged

refactor(types): clean up dynamic types #51

merged 11 commits into from
Jan 11, 2022

Conversation

mabdh
Copy link
Member

@mabdh mabdh commented Jan 6, 2022

Tasks

  • Add Elasticsearch migration to migrate command to create indices for all of our available types
  • Change Type to enum
  • Remove types CRUD APIs

@mabdh mabdh linked an issue Jan 6, 2022 that may be closed by this pull request
refactor: clean up dynamic types #50
Closed
@mabdh mabdh changed the title refactor: cleanup dynamic types refactor: clean up dynamic types Jan 6, 2022
@mabdh mabdh changed the title refactor: clean up dynamic types refactor(types): clean up dynamic types Jan 6, 2022
@mabdh mabdh self-assigned this Jan 6, 2022
@mabdh mabdh added the enhancement New feature or request label Jan 6, 2022
@mabdh mabdh marked this pull request as draft January 6, 2022 09:18
@mabdh mabdh marked this pull request as ready for review January 6, 2022 09:27
@mabdh mabdh force-pushed the cleanup-dynamic-types branch from 8b1dbb7 to a2c4c19 Compare January 10, 2022 06:27
StewartJingga
StewartJingga reviewed Jan 10, 2022
View reviewed changes
StewartJingga
StewartJingga reviewed Jan 11, 2022
View reviewed changes
@mabdh mabdh force-pushed the cleanup-dynamic-types branch from 62ae5ac to b1d2c50 Compare January 11, 2022 05:13
StewartJingga
StewartJingga approved these changes Jan 11, 2022
View reviewed changes
Copy link
Contributor

@StewartJingga StewartJingga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@StewartJingga StewartJingga merged commit 8111b08 into main Jan 11, 2022
@StewartJingga StewartJingga deleted the cleanup-dynamic-types branch January 11, 2022 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StewartJingga StewartJingga StewartJingga approved these changes

@ravisuhag ravisuhag Awaiting requested review from ravisuhag

Assignees

@mabdh mabdh

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

refactor: clean up dynamic types
2 participants
@mabdh @StewartJingga