Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add pagination when fetching records #42

Merged
merged 3 commits into from
Jan 9, 2022
Merged

Conversation

StewartJingga
Copy link
Contributor

/v1/types/{type}/records

Accept from and size querystrings

/v1/types/{type}/records?from=10&size=30

Default sort by name

Now results are sorted by name

Change response payload to

{
  "data": [
    {"urn": "test-urn", ...},
    ...
  ],
  "count": 5,
  "total": 100
}

@StewartJingga StewartJingga added the enhancement New feature or request label Dec 27, 2021
@StewartJingga StewartJingga requested a review from mabdh December 27, 2021 04:56
@StewartJingga StewartJingga self-assigned this Dec 27, 2021
@StewartJingga StewartJingga linked an issue Dec 27, 2021 that may be closed by this pull request
@StewartJingga StewartJingga merged commit b22e68d into main Jan 9, 2022
@StewartJingga StewartJingga deleted the pagination branch January 9, 2022 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: add pagination when fetching records
2 participants