Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(discovery): search by record's field name #41

Merged
merged 6 commits into from
Dec 17, 2021
Merged

Conversation

mabdh
Copy link
Member

@mabdh mabdh commented Dec 14, 2021

No description provided.

@mabdh mabdh added the enhancement New feature or request label Dec 14, 2021
@mabdh mabdh marked this pull request as ready for review December 14, 2021 11:53
@mabdh mabdh self-assigned this Dec 14, 2021
…ield

feat(search): use query string to search by field
chore: comment out elasticsearch logger
fix(discovery): update search by field query to match query
chore(discovery): update swagger search api with searchby query param
@mabdh mabdh requested a review from StewartJingga December 16, 2021 12:26
Copy link
Contributor

@StewartJingga StewartJingga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@StewartJingga StewartJingga merged commit a0c1a23 into main Dec 17, 2021
@StewartJingga StewartJingga deleted the searchby-field branch December 17, 2021 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(discovery): search by fields (description, data owner, classification tags, and column's table)
3 participants