Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(discovery): add search suggestion api #40

Merged
merged 5 commits into from
Dec 16, 2021
Merged

feat(discovery): add search suggestion api #40

merged 5 commits into from
Dec 16, 2021

Conversation

StewartJingga
Copy link
Contributor

@StewartJingga StewartJingga commented Dec 13, 2021 •
edited
Loading

Discovery

Expose new endpoint /v1/search/suggest with below response

Request

[GET] /v1/search/suggest?text="tes"

Response

{
  "suggestions": ["test", "tesla"]
}

@StewartJingga StewartJingga added the enhancement New feature or request label Dec 13, 2021
@StewartJingga StewartJingga requested a review from mabdh December 13, 2021 05:30
@StewartJingga StewartJingga self-assigned this Dec 13, 2021
@StewartJingga StewartJingga linked an issue Dec 13, 2021 that may be closed by this pull request
feat(discovery): auto suggestion (search-as-you-type) on search #33
Closed
@mabdh
Copy link
Member

mabdh commented Dec 14, 2021

All look good. LGTM.

@StewartJingga
Copy link
Contributor Author

@mabdh changing to completion suggester 🙏
e9d683b

@StewartJingga StewartJingga requested a review from mabdh December 16, 2021 03:06
@mabdh
Copy link
Member

mabdh commented Dec 16, 2021

@mabdh changing to completion suggester 🙏 e9d683b

I am testing this in integration now.

@mabdh
Copy link
Member

mabdh commented Dec 16, 2021

Looks good. LGTM

@StewartJingga StewartJingga merged commit 9fc7637 into main Dec 16, 2021
@StewartJingga StewartJingga deleted the add-search-suggestion-api branch December 16, 2021 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mabdh mabdh Awaiting requested review from mabdh

Assignees

@StewartJingga StewartJingga

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat(discovery): auto suggestion (search-as-you-type) on search
2 participants
@StewartJingga @mabdh