fix: store, retrieve asset.url #209

sudo-suhas · 2023-02-21T12:08:38Z

Add column to assets table for URL.
Store the asset's URL field in DB as part of insert/upsert.
Retrieve the asset's URL field from DB for fetch APIs.
Refactor UPDATE statement to use squirrel for easier maintenance.

- Add column to assets table for URL. - Store the asset's URL field in DB as part of insert/upsert. - Retrieve the asset's URL field from DB for fetch APIs. - Refactor UPDATE statement to use squirrel for easier maintenance.

coveralls · 2023-02-21T12:12:05Z

Pull Request Test Coverage Report for Build 4232473912

24 of 26 (92.31%) changed or added relevant lines in 4 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-0.02%) to 86.107%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
internal/store/postgres/asset_repository.go	17	19	89.47%

Files with Coverage Reduction	New Missed Lines	%
internal/store/postgres/asset_repository.go	1	77.37%

Totals
Change from base Build 4232425834:	-0.02%
Covered Lines:	5008
Relevant Lines:	5816

💛 - Coveralls

haveiss · 2023-02-22T03:01:13Z

internal/store/postgres/asset_repository.go

@@ -775,6 +776,7 @@ func (r *AssetRepository) getAssetSQL() sq.SelectBuilder {
 		a.service as service,
 		a.description as description,
 		a.data as data,
+		COALESCE(a.url, '') as url,


how this compared to set url default to '' when altering table?

Altering a table with default value used to take a lock for updating all rows (which would block reads and writes). This looks to have been fixed in PG 11 but I wasn't aware of that while making these changes.

fix: store, retrieve asset.url

cc6853d

- Add column to assets table for URL. - Store the asset's URL field in DB as part of insert/upsert. - Retrieve the asset's URL field from DB for fetch APIs. - Refactor UPDATE statement to use squirrel for easier maintenance.

sudo-suhas requested a review from haveiss February 21, 2023 12:08

haveiss approved these changes Feb 22, 2023

View reviewed changes

ravisuhag merged commit 495c666 into main Feb 22, 2023

ravisuhag deleted the fix-asset-url-fetch branch February 22, 2023 04:24

sudo-suhas mentioned this pull request Feb 24, 2023

url field is always empty even after inserting/upserting #187

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: store, retrieve asset.url #209

fix: store, retrieve asset.url #209

sudo-suhas commented Feb 21, 2023

coveralls commented Feb 21, 2023

haveiss Feb 22, 2023 •

edited

Loading

sudo-suhas Feb 24, 2023

fix: store, retrieve asset.url #209

fix: store, retrieve asset.url #209

Conversation

sudo-suhas commented Feb 21, 2023

coveralls commented Feb 21, 2023

Pull Request Test Coverage Report for Build 4232473912

💛 - Coveralls

haveiss Feb 22, 2023 • edited Loading

Choose a reason for hiding this comment

sudo-suhas Feb 24, 2023

Choose a reason for hiding this comment

haveiss Feb 22, 2023 •

edited

Loading