Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Patch asset's lineage #195

Merged
merged 1 commit into from
Jan 17, 2023
Merged

fix: Patch asset's lineage #195

merged 1 commit into from
Jan 17, 2023

Conversation

sudo-suhas
Copy link
Contributor

  • For the UpsertPatchAsset RPC, when no upstreams and downstreams are specified in the request, skip overwriting the asset's lineage unless OverwriteLineage flag is set to true.
  • Bump up the proton commit in Makefile to pull in changes from feat: UpsertPatchAsset - allow to overwrite lineage proton#238 + generate protos.

@coveralls
Copy link

coveralls commented Jan 16, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 3936226714

  • 31 of 42 (73.81%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.1%) to 86.06%
Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/server/v1beta1/asset.go 19 30 63.33%
Totals Coverage Status
Change from base Build 3930013070: -0.1%
Covered Lines: 4982
Relevant Lines: 5789
💛 - Coveralls

@sudo-suhas
fix: Patch asset's lineage
3273a9e 
- For the UpsertPatchAsset RPC, when no upstreams and downstreams are
  specified in the request, skip overwriting the asset's lineage unless
  OverwriteLineage flag is set to true.
- Bump up the proton commit in Makefile to pull in changes from
  raystack/proton#238 + generate protos.
@sudo-suhas sudo-suhas force-pushed the fix-patch-upsert-lineage branch from c50af8e to 3273a9e Compare January 17, 2023 05:02
@sudo-suhas sudo-suhas marked this pull request as ready for review January 17, 2023 05:02
StewartJingga
StewartJingga approved these changes Jan 17, 2023
View reviewed changes
Copy link
Contributor

@StewartJingga StewartJingga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sudo-suhas sudo-suhas merged commit a587fff into main Jan 17, 2023
@sudo-suhas sudo-suhas deleted the fix-patch-upsert-lineage branch January 17, 2023 05:14
@sudo-suhas sudo-suhas mentioned this pull request Feb 20, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StewartJingga StewartJingga StewartJingga approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sudo-suhas @coveralls @StewartJingga